Add plugin to copy binary files from the scala 2 artefacts #22480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
added
release-notes
hamzaremmal
force-pushed
the
hr/scala-artefact
branch
from
06e8deb to
b54b19b
Compare
This was referenced Feb 1, 2025
hamzaremmal
force-pushed
the
hr/scala-artefact
branch
from
9b0e761 to
8cb6b70
Compare
This was referenced Feb 4, 2025
hamzaremmal
force-pushed
the
hr/scala-artefact
branch
3 times, most recently
from
b0059ff to
b4f9001
Compare
hamzaremmal
added a commit
that referenced
this pull request
Feb 7, 2025
…22519) Scala 2 generates extension methods for Value Classes before pickling while Scala 3 generates them after. Now that we are working on compiling the Scala 2 stdlib with dotty (#22480), and therefore generating tasty files for the stdlib, we will have to distinguish between scala 2 that was unpickled and scala 2 code coming from tasty. For that, we currently have a flag, but it is not very useful apart from some very specific details where a workaround exists. This PR, removes one of 2 places where this flag is used. The [second place](https://github.com/scala/scala3/blob/aa9db1f682de634743af6d7077d5ed752430a487/compiler/src/dotty/tools/dotc/transform/YCheckPositions.scala#L51) will be removed once we inline the missing symbol in `Predef.scala` (after #22480) is merged.
hamzaremmal
force-pushed
the
hr/scala-artefact
branch
from
b4f9001 to
cae8dd2
Compare
hamzaremmal
added a commit
that referenced
this pull request
Feb 12, 2025
) When compiling under `-Ycompile-scala2-library`, we should consider the source code as Scala 2. This change will allow using Scala 2's erasure instead of Scala 3's. Related to #22480
hamzaremmal
force-pushed
the
hr/scala-artefact
branch
2 times, most recently
from
4633da3 to
a657522
Compare
hamzaremmal
force-pushed
the
hr/scala-artefact
branch
3 times, most recently
from
78b24d1 to
07afa47
Compare
hamzaremmal
force-pushed
the
hr/scala-artefact
branch
from
07afa47 to
c8f6c4a
Compare
|
We will tackle the issue of generic signatures, and the logic to build the jar artifact in a subsequent PR |
hamzaremmal
changed the title
sjrd
approved these changes
Mar 10, 2025
|
Does it really require minor release or is it just to be on a safe side? Thinking about it in terms of Scala LTS |
|
What would the LTS even do with this, if it were backported? |
|
Yeah, I might have been overthinking things here. |
tgodzik
removed
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #22043
Supersedes #22399
Blocked by:
AnyValbetween Scala 2 and Scala 3 #22493AnyValunder-Ycompile-scala2-library#22533$init$trait constructors under-Ycompile-scala2-library#22496@publicInBinaryin 3.7.0 #22497@publicInBinarydoesn't have any effect on secondary constructors #22498Array[Null]andArray[Nothing]#22515-Ycompile-scala2-library#22520Not blocking, but related: